Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ggpar() to gg_par() #5899

Merged
merged 2 commits into from
May 24, 2024
Merged

Rename ggpar() to gg_par() #5899

merged 2 commits into from
May 24, 2024

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented May 21, 2024 •
edited

This PR aims to fix #5897.

Instead of naming our function ggpar(), we name it gparam() instead.
If you feel strongly about the name, feel free to leave suggestions.

thomasp85
thomasp85 reviewed May 22, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think gg_par() is more in line with our naming for helpers (e.g. gg_dep()), and it may be easier to not accidentally mistype as it deviates from gpar() earlier

@teunbrand teunbrand changed the title Rename ggpar() to gparam() Rename ggpar() to gg_par() May 23, 2024
thomasp85
thomasp85 approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit e3a4daf into tidyverse:main May 24, 2024
11 checks passed
@teunbrand teunbrand deleted the rename_ggpar branch May 24, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ggplot2::ggpar() has a namespace conflict with ggpubr::ggpar()
2 participants
@teunbrand @thomasp85