Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback for facet_wrap(as.table) #5898

Open
teunbrand opened this issue May 21, 2024 · 0 comments · May be fixed by #5907
Open

Fallback for facet_wrap(as.table) #5898

teunbrand opened this issue May 21, 2024 · 0 comments · May be fixed by #5907
Labels
breaking change ☠️ API change likely to affect existing code

Comments

@teunbrand
Copy link
Collaborator

teunbrand commented May 21, 2024 •
edited

In #5855, we internally removed as.table and resolved it in the constructor.
Reverse dependency checks revealed that several facet extensions rely on as.table to be present.
It would be nice to have a fallbacks in place to not trigger errors in extensions.
This was referenced May 21, 2024
Closed
Open
@teunbrand teunbrand added the breaking change ☠️ API change likely to affect existing code label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fallback for dir = 'h'/'v' teunbrand/ggplot2
Restore as.table teunbrand/ggplot2
1 participant
@teunbrand