New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] TigerRAG: Parameterized embedding model ID in movie demo #4

Open

lilinwang opened this issue Nov 3, 2023 · 0 comments

Labels

Collaborator

lilinwang commented Nov 3, 2023

Currently, the embedding model is hardcoded as "bert-base-uncased":

tiger/TigerRag/tigerrag/demo/movie_recs/demo.py

Line 21 in 8ad8d38

tokenizer = BertTokenizer.from_pretrained('bert-base-uncased')

. It could be useful to Parameterized it, and compare results from different embedding models.

lilinwang added the enhancement label

leannezhang mentioned this issue

[Enhancement] Refactor code to parameterize model selection #8

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment