Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove facilty params/concept from all of tinkerbell #389

Open
mmlb opened this issue Dec 11, 2020 · 1 comment
Open

Remove facilty params/concept from all of tinkerbell #389

mmlb opened this issue Dec 11, 2020 · 1 comment
Labels
breaking-change Denotes a PR that introduces potentially breaking changes that require user action. kind/design Categorizes issue or PR as related to design. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mmlb
Copy link
Contributor

mmlb commented Dec 11, 2020 •
edited

Facility concept is very EM specific and as such should be removed. I'm pretty sure we don't need it as any current use of it would be better served with explicit URLs instead of plugging facility into a hard code string "template".
@mmlb mmlb changed the title Remove facilty params/concept from Remove facilty params/concept from all of tinkerbell Dec 11, 2020
@mmlb mmlb mentioned this issue Dec 11, 2020
Merged
3 tasks
@gianarb
Copy link
Contributor

gianarb commented Dec 24, 2020

I had quick look at it and this is a bc break I think, the cert endpoint will break because it requires a facility for example.

So, how do we want to proceed? bc break?

@mmlb

@gianarb gianarb added breaking-change Denotes a PR that introduces potentially breaking changes that require user action. triage/discuss Indicates a PR or issue that requires discussion labels Dec 24, 2020
@tstromberg tstromberg added the kind/design Categorizes issue or PR as related to design. label Aug 27, 2021
@tstromberg tstromberg added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed triage/discuss Indicates a PR or issue that requires discussion labels Sep 7, 2021
@chrisdoherty4 chrisdoherty4 mentioned this issue Jan 18, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Denotes a PR that introduces potentially breaking changes that require user action. kind/design Categorizes issue or PR as related to design. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstromberg @mmlb @gianarb