Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller component to identify non-unique Hardware ID values #842

Open
chrisdoherty4 opened this issue Nov 18, 2023 · 0 comments
Open
Assignees

Comments

@chrisdoherty4
Copy link
Member

Summary

Hardware needs a unique identifier that can be used to pass to Tink Agent instances. If the value isn't unique within the whole cluster it leads to undefined behavior. This task is to build a system component that will provide information to operators that a Hardware resource is invalid.

Solutions

  1. We are experimentally checking uniqueness of MACs and IPs in the Hardware admission webhook. We could expand this to include the Hardware ID.
  2. Add conditions to Hardware resources that indicate a resource is valid. The MAC and IP uniqueness checks would be included with the ID check.
  3. In addition to (2) we can populate an Event on Hardware resources further indicating its invalid.

Additional data as specified in (2) could further be used in decisions around Workflow dispatch. For example, we could refuse to dispatch a Workflow if the associated Hardware resource is invalid.

@chrisdoherty4 chrisdoherty4 self-assigned this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant