Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: 将 Easydict 最低系统支持版本修改为 macOS 13.0 #534

Open
tisfeng opened this issue May 4, 2024 · 4 comments
Open

dev: 将 Easydict 最低系统支持版本修改为 macOS 13.0 #534

tisfeng opened this issue May 4, 2024 · 4 comments
Assignees
Labels

Comments

@tisfeng
Copy link
Owner

tisfeng commented May 4, 2024

目前设置页已使用 SwiftUI 重写,而许多 SwiftUI API 都要求 macOS 13.0,未来我们还将使用 SwiftUI 重写查询窗口页面,因此决定将最低系统支持版本从 macOS 11.0 修改为 macOS 13.0。

该 issue 除了将 Minimum Deployments 修改为 macOS 13.0,还包括以下内容修改:

  • 移除旧的设置页相关代码。
  • 移除之前设置页使用的第三方库,如 MASPreferences,MASShortcut 等。
  • 移除有关系统版本判断的代码,如 @available(macOS 13, *) 等。
@tisfeng tisfeng added the dev label May 4, 2024
@tisfeng
Copy link
Owner Author

tisfeng commented May 13, 2024

@AkaShark 你能做一下这个吗

@AkaShark
Copy link
Collaborator

okay 我明天先梳理下代码,有问题我们在这个issue中沟通

@AkaShark AkaShark self-assigned this May 13, 2024
@AkaShark
Copy link
Collaborator

@tisfeng "移除旧的设置页相关代码" 移除就的设置页相关的代码,我们是不是直接把之前的Launch In SwiftUI App mode给取掉了,直接走SwiftUI

@tisfeng
Copy link
Owner Author

tisfeng commented May 14, 2024

是的,Launch In SwiftUI App mode 这个也可以删除了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants