Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

managedonly setting does not work correctly #35

Open
tstraley opened this issue Apr 7, 2023 · 1 comment
Open

managedonly setting does not work correctly #35

tstraley opened this issue Apr 7, 2023 · 1 comment

Comments

@tstraley
Copy link

tstraley commented Apr 7, 2023

When the managedonly configuration setting is enabled, this tool ends up skipping those secrets that are properly managed by imagepullsecret-patcher, and does actually overwrite secrets that are not managed by it.

It appears to be a simple bug in the evaluation here: https://github.com/titansoft-pte-ltd/imagepullsecret-patcher/blob/master/main.go#L156

This should actually be

		if configManagedOnly && !isManagedSecret(secret) {
			return fmt.Errorf("[%s] Secret is present but unmanaged", namespace)
		}
@tstraley
Copy link
Author

tstraley commented Apr 7, 2023

This project does not appear to be actively maintained, so I'm just going to leave this issue here for others to be aware. If PRs start getting acknowledged again in the future here, I can submit a PR to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant