Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/multiple hooks #20

Closed
wants to merge 2 commits into from
Closed

Conversation

ssbarnea
Copy link

@ssbarnea ssbarnea commented Apr 13, 2017

Fixes #19

@ssbarnea ssbarnea changed the title #19 Fix/multiple hooks Fix/multiple hooks Apr 13, 2017
@tommarshall
Copy link
Owner

Hi @ssbarnea,

Thanks for the PR.

Multiple hooks (chaining) has unfortunately been a long running challenge with Git.

I appreciate the users of git-good-commit may run into this issue, however I think that resolving it is out of scope for any single commit hook, this project included. There's no agreed standard, so if every hook tried to offer it's own solution for chaining hooks they'd likely end up conflicting.

Rather than implement a solution within the hook itself I'd prefer to link to documentation so that users that require the hook chaining can solve this issue for themselves, e.g. http://stackoverflow.com/a/8734391

Tom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible with git-review hooks
2 participants