Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donut chart: one sector has a rounded cap in the wrong direction #27

Open
vibl opened this issue Mar 4, 2019 · 3 comments
Open

Donut chart: one sector has a rounded cap in the wrong direction #27

vibl opened this issue Mar 4, 2019 · 3 comments

Comments

@vibl
Copy link

vibl commented Mar 4, 2019

There seems to be a bug in the donut chart with rounded line caps:

https://toomuchdesign.github.io/react-minimal-pie-chart/index.html?selectedKind=Donut%20Chart&selectedStory=custom%20%22lineWidth%22%20%2B%20%22rounded%22&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel

In the example, the yellow sector should end with a rounded cap in the other way.

@vibl
Copy link
Author

vibl commented Mar 6, 2019

A workaround: https://github.com/vibl/react-minimal-pie-chart/blob/332d926755ea1a8bfe53d13a59af84fa5f7d58d6/src/ReactMinimalPieChart.js#L103

@toomuchdesign
Copy link
Owner

Welcome @vibl,
and thanks for filing this issue.

I had a look to the suggested workaround and, although it provides a fix for your use case, it might not play well with some existing feature (segments animation, for example).

I will take some time to think about it.
Greetings!

@rinat-lucky
Copy link

Hi! Could you please duplicate the sample code to solve this problem? Unfortunately, the link is not available at the moment. Perhaps there is another (new) variant of the solution. Thanks!
@vibl @toomuchdesign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants