You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The return type of RequestHandler.get_argument depends on a default being provided or not, accounted for using appropriate overloads. Unfortunately, the same isn't true for RequestHandler.get_body_argument and RequestHandler.get_query_argument, which simply declare Optional[str].
Perhaps those need similar overloads, or they could be moved over to RequestHandler._get_argument, called by all...? I'm not sure if most type checkers would infer the rest from that.
The text was updated successfully, but these errors were encountered:
pcavalar
added a commit
to pcavalar/tornado
that referenced
this issue
May 17, 2024
The return type of
RequestHandler.get_argument
depends on adefault
being provided or not, accounted for using appropriate overloads. Unfortunately, the same isn't true forRequestHandler.get_body_argument
andRequestHandler.get_query_argument
, which simply declareOptional[str]
.Perhaps those need similar overloads, or they could be moved over to
RequestHandler._get_argument
, called by all...? I'm not sure if most type checkers would infer the rest from that.The text was updated successfully, but these errors were encountered: