Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser freezes when updating chart data. #1500

Open
pkquell opened this issue Jan 22, 2024 · 1 comment
Open

Browser freezes when updating chart data. #1500

pkquell opened this issue Jan 22, 2024 · 1 comment
Labels
bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors.
Milestone

Comments

@pkquell
Copy link

pkquell commented Jan 22, 2024

Lightweight Charts™ Version: 4.1.2

Steps/code to reproduce:

const chart = LightweightCharts.createChart(document.getElementById("chart"));
let series = chart.addLineSeries();
series.update({
	"time": "2023-12-27",
	"value": 459761321634093
});

Actual behavior:

Browser freezes.

Expected behavior:

Screenshots:

CodeSandbox/JSFiddle/etc link:

https://jsfiddle.net/L3rvudpc/

@SlicedSilver SlicedSilver added bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors. labels Jan 23, 2024
@SlicedSilver
Copy link
Contributor

Thanks @pkquell

The library does appear to have an issue when the data value becomes very large. The test value is less than Number.MAX_SAFE_INTEGER so it is something that should be fixable in the library without needing to use BigInt. However support for BigInt is really good across browsers so it should be safe to use that if required.

@SlicedSilver SlicedSilver added this to the 5.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior. good first issue Good issue for first-time contributors.
Projects
None yet
Development

No branches or pull requests

2 participants