Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests fail when run in VSCode in Windows #300

Open
Almenon opened this issue Jan 21, 2024 · 0 comments
Open

tests fail when run in VSCode in Windows #300

Almenon opened this issue Jan 21, 2024 · 0 comments
Assignees
@Almenon
Labels
bug Something isn't working

Comments

@Almenon
Copy link
Collaborator

Almenon commented Jan 21, 2024

Certain tests fail when ran on VSCode test explorer in windows. I debugged the code and found out the issue is the code assumes the drive letter is uppercase, but in this specific scenario the letter is lowercase. NTFS is case insensitive so the code should not assume the drive letter is uppercase. It's easily fixed by adjusting the regex.

Almenon@8f3d6f2
@Almenon Almenon mentioned this issue Jan 21, 2024
Closed
@Almenon Almenon changed the title [bug] tests fail when run in VSCode in Windows tests fail when run in VSCode in Windows Jan 27, 2024
@Almenon Almenon added the bug Something isn't working label Jan 27, 2024
@Almenon Almenon self-assigned this Jan 27, 2024
@Almenon Almenon mentioned this issue Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Almenon Almenon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to go 1.21, fix #300 Almenon/terragrunt-atlantis-config
1 participant
@Almenon