Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.21, fix #300 #301

Closed
wants to merge 15 commits into from

Conversation

Almenon
Copy link
Collaborator

@Almenon Almenon commented Jan 21, 2024

Pull Request

Related Github Issues

Description

I confirmed the Build and test code workflow is passing with the following changes

  • Upgrade to go 1.21. Ideally we would support 1.20 too, but there was some weird issue where Github CI would run 1.21 even if I specified '1.20'. Supporting older go versions is not that important because the project compiles to an executable, so I decided to just drop 1.20 support.
  • Upgrade certain Github actions
  • Fix tests fail when run in VSCode in Windows聽#300
  • Add personal vscode workspace files to gitignore
  • removed actions/cache@v2 - latest go action has builtin cache
  • Run go mod tidy

Security Implications

System Availability

  • [none]

@Almenon Almenon changed the title Upgrade to go 121, fix #300 Upgrade to go 1.21, fix #300 Jan 21, 2024
@Almenon
Copy link
Collaborator Author

Almenon commented Jan 27, 2024

Closing, will re-open with fixed conflicts

@Almenon Almenon closed this Jan 27, 2024
@Almenon Almenon mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail when run in VSCode in Windows
1 participant