Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable search using duration #2

Open
aneesh1122 opened this issue May 4, 2024 · 3 comments
Open

Enable search using duration #2

aneesh1122 opened this issue May 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@aneesh1122
Copy link

aneesh1122 commented May 4, 2024

Let us get the results in lrclib.net after entering the duration.

Example

  1. I searched 'Numb'. Got many results.
    Screenshot_2024-05-04-19-18-49-591_com.brave.browser-edit.jpg

  2. I want to get the lyrics of the second song with runtime 3:06. I searched for 'Numb 3:06' but got no results
    Screenshot_2024-05-04-19-20-24-412_com.brave.browser.png

Please let us get results by using runtime

Tip : also include results for 'Numb 3:05' and 'Numb 3:07' when searched for 'Numb 3:06'

@tranxuanthang tranxuanthang added the enhancement New feature or request label May 4, 2024
@Batwam
Copy link

Batwam commented May 14, 2024

As per the API

Note: The provided duration is crucial. LRCLIB will attempt to provide the lyrics only when the duration matches the record in LRCLIB's database, or at least with a difference of ±2 seconds in duration.

So it should probably show any result within ±2 seconds

@aneesh1122
Copy link
Author

As per the API

Note: The provided duration is crucial. LRCLIB will attempt to provide the lyrics only when the duration matches the record in LRCLIB's database, or at least with a difference of ±2 seconds in duration.

So it should probably show any result within ±2 seconds

even ±2 seconds will do if it means I'll get the lyrics easily.

@Batwam
Copy link

Batwam commented May 14, 2024

Yeah, it's the same thing as what you suggested in the Tip at the end of your original post, just a bit more tolerant and consistent with the LibLRC API.

@tranxuanthang tranxuanthang transferred this issue from tranxuanthang/lrcget May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants