Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddable version of JSON Hero - needed feature #143

Open
babazookz opened this issue Dec 7, 2022 · 6 comments
Open

Embeddable version of JSON Hero - needed feature #143

babazookz opened this issue Dec 7, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@babazookz
Copy link

I am using a JSON Hero tool a lot and whenever I use it, I have to open in another tab and continue browsing the JSON.

So, I was thinking is there a chance to use JSON Hero tool on the same page where I am opening it from - my app page by using <iframe> for example?

@ericallam ericallam added the enhancement New feature or request label Dec 22, 2022
@abhaykumarvats
Copy link
Contributor

@babazookz / @ericallam This seems like a great idea. I would like to work on it. I just need some guidance on how to go on about developing it. Thanks.

@matt-aitken
Copy link
Member

Displaying the site in an iframe will probably work already, but I'm assuming we want to hide some of the UI?

Some extra query params could be added to the url, e.g. ?embed=true and that would hide the top nav bar for example.

@abhaykumarvats
Copy link
Contributor

@matt-aitken Alright, I will take this one. Let's see what I come up with.

@abhaykumarvats
Copy link
Contributor

abhaykumarvats commented Apr 18, 2023

@babazookz What's the flow in your mind? How would you want to open JSON Hero in an embedded window? Do you have high-level steps in mind. Like, what should a user do to get to the embedded window. Would be of great help. Thanks.

@babazookz
Copy link
Author

@babazookz What's the flow in your mind? How would you want to open JSON Hero in an embedded window? Do you have high-level steps in mind. Like, what should a user do to get to the embedded window. Would be of great help. Thanks.

Hey, to be honest, the only thing I have is a high level idea. It goes like this, imagine situation where I want to use JSON hero on my own page as a invokable Modal window.

Lets say I am building an app which works with JSON files and at one point I want to open a JSON file without redirecting towards JSON hero page but invoking the iframe within some Modal window within my personal app.

Did I help you a bit?

@changdy
Copy link

changdy commented Jun 28, 2023

@ericallam @babazookz

Hello ,My firends , I used jsoncrack for a months, but I think JSON-HERO is more suitable for me .
It is very to use , and can do much more things than I thought.
Now , I meet the same problem , I want to embe it into my page too.

First , i want to deploy JSON-HERO in my own computer , because it is not very easy for Chinese to visit foreign website( government policy)

For jsoncrack , I can deploy it by run docker build , but I do not know how to do this with JSON-HERO .

Second , I want to embed JSON-HERO into my page too . for jsoncrack (https://codepen.io/AykutSarac/pen/QWBbpqx) , I can use contentWindow.postMessage to pase json text , dose JSON-HERO support this function ? Will you develop this

I not a native English speaker , so my English is very poor .

Thanks for reading my letter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants