Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for silhouette_samples() functionalities like sklearn. #451

Open
srimantacse opened this issue May 18, 2023 · 5 comments
Open

Support for silhouette_samples() functionalities like sklearn. #451

srimantacse opened this issue May 18, 2023 · 5 comments

Comments

@srimantacse
Copy link

Is there any support for silhouette_samples() functionalities as sklearn has.

@rtavenar
Copy link
Member

Hi,

We don't have support for silhouette_samples at the moment.

In terms of implementation, given the current implementation of silhouette_score (https://github.com/tslearn-team/tslearn/blob/main/tslearn/clustering/utils.py#L66) that heavily relies on sklearn's implem, it should be pretty much the same for one willing to adapt silhouette_samples:

  1. compute cross-similarity metrics between points
  2. rely on sklearn's implementation using metric="precomputed"

Anyone is welcome to open a PR on the topic.

@srimantacse
Copy link
Author

@rtavenar thanks for the help. Able to get the sample score as you mentioned the steps. Thanks again.

@rtavenar
Copy link
Member

@srimantacse would you be willing to contribute your code to tslearn ? If so, we would be happy to help you along the process.

@srimantacse
Copy link
Author

@rtavenar please share me the process, I will do it.
Request to give me some time considering my schedule.
Share me the process.

@rtavenar
Copy link
Member

You can find info there: https://github.com/tslearn-team/tslearn/blob/main/CONTRIBUTING.md#more-details-on-pull-requests

No problem if it takes some time, of course, it's always great to welcome new contributors

@rtavenar rtavenar reopened this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants