Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can only delete draft on reopening #4434

Closed
Lakoja opened this issue May 9, 2024 · 1 comment · Fixed by #4484
Closed

Can only delete draft on reopening #4434

Lakoja opened this issue May 9, 2024 · 1 comment · Fixed by #4484
Labels
bug

Comments

@Lakoja
Copy link
Collaborator

Lakoja commented May 9, 2024 •
edited

Detailed description

  1. Compose toot
  2. Close and save as draft
  3. Open the draft
  4. Close that again

A dialog appears which only allows to "Continue editing" and "Delete". So you can either leave and delete or send the toot.

Expected: Without a change to the toot content there should be no dialog on quitting.
With a change the dialog should be "Discard changes" or "Update draft".

Steps to reproduce the problem

No response

Debug information

...
@Lakoja Lakoja added the bug label May 9, 2024
@texttheater
Copy link

+1. I cannot comprehend what could possibly have prompted anyone to implement this change. It was working perfectly before. Now we get the same broken behavior that Twitter used to have.

@connyduck connyduck mentioned this issue Jun 2, 2024
Merged
connyduck added a commit that referenced this issue Jun 5, 2024
@connyduck
correctly set currentContent in ComposeViewModel.setup (#4484)
adbe694 
Without this, the check that decides if the dialog on close should be
shown operates on incorrect data.

closes #4434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correctly set currentContent in ComposeViewModel.setup tuskyapp/Tusky
2 participants
@texttheater @Lakoja