Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search on Sort menu #4368

Closed
Bonapara opened this issue Mar 7, 2024 · 15 comments · Fixed by #5045
Closed

Add a search on Sort menu #4368

Bonapara opened this issue Mar 7, 2024 · 15 comments · Fixed by #5045
Assignees
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours

Comments

@Bonapara
Copy link
Member

Bonapara commented Mar 7, 2024

Current Behavior

CleanShot 2024-03-07 at 18 26 36

Desired Behavior

The sort menu currently lacks a 'Search' function. To optimize keyboard navigation and handle numerous fields effectively, we propose the addition of a search feature at the top:

CleanShot 2024-03-07 at 18 27 22

Figma

https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=2979-195483&mode=design&t=LORfESmPs8dJ3RY2-11

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours labels Mar 7, 2024
@Bonapara
Copy link
Member Author

Bonapara commented Mar 7, 2024

Related to #4367 → Implement Search Feature in Filter Menu

@rhlshah
Copy link

rhlshah commented Mar 8, 2024

I would love to take this up!

@Bonapara
Copy link
Member Author

Bonapara commented Mar 8, 2024

@ahmadjafari86, do you want to handle this one too, related to #4367? If not I'll assign you @rhlshah :)

@ahmadjafari86
Copy link
Contributor

@Bonapara
ok, I think it's good for me to do it because of its relation to my task.

@ahmadjafari86 ahmadjafari86 removed their assignment Mar 18, 2024
@ahmadjafari86
Copy link
Contributor

Hey @Bonapara, just a heads up, I've unassigned myself from this task. I'm having trouble running the server on my local system.

@Bonapara
Copy link
Member Author

@rhlshah are you still interested? Thanks for giving it a try @ahmadjafari86!

@rhlshah
Copy link

rhlshah commented Mar 19, 2024

Yes @Bonapara , I am still interested

@Bonapara
Copy link
Member Author

Assigning you then @rhlshah! Thanks 🙏

@Bonapara
Copy link
Member Author

Do you also want to tackle #4367 @rhlshah?

@rhlshah
Copy link

rhlshah commented Mar 19, 2024

Yes, I could take that up too

@Bonapara
Copy link
Member Author

Bonapara commented Mar 20, 2024

Can you comment on it so I can assign you? Thank you!

@rathodvinod5
Copy link
Contributor

@Bonapara is this issue closed, if not, I will be happy to solve this.

@Bonapara
Copy link
Member Author

Hi @rathodvinod5, thanks for contributing! I already assigned you #4351, do you still want this one as well?

@rathodvinod5
Copy link
Contributor

@Bonapara, Yes I am interested to solve this issue too.

@Bonapara
Copy link
Member Author

@rhlshah, I'm unassigning you from this task, as it's been a month. Thank you!

@Bonapara Bonapara assigned rathodvinod5 and unassigned rhlshah Apr 15, 2024
Weiko added a commit that referenced this issue Apr 25, 2024
Closes #4368

---------

Co-authored-by: Weiko <corentin@twenty.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: hours
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants
@Bonapara @rhlshah @ahmadjafari86 @rathodvinod5 and others