Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAU I want to re-order my views with drag & drop. #4782

Closed
lucasbordeau opened this issue Apr 3, 2024 · 4 comments · Fixed by #5002
Closed

AAU I want to re-order my views with drag & drop. #4782

lucasbordeau opened this issue Apr 3, 2024 · 4 comments · Fixed by #5002
Assignees
@gitstart-twenty
Labels
good first issue Good for newcomers ready scope: front Issues that are affecting the frontend side only

Comments

@lucasbordeau
Copy link
Contributor

Scope & Context

In the view list :

image

Current behavior

I can create and edit views but not re-order them.

Expected behavior

I want to be able to re-order my views in the list, the same way that I do it with my favorites.
@lucasbordeau lucasbordeau added good first issue Good for newcomers blocked: tech spec needed and removed good first issue Good for newcomers labels Apr 3, 2024
@lucasbordeau
Copy link
Contributor Author

@charlesBochet Do we need to add a position field on views ?

@charlesBochet
Copy link
Member

charlesBochet commented Apr 4, 2024 •
edited

Yes!
position field of type POSITION

To implement this issue, you can take inspiration for person.position (generally any record position)

Regarding the drag and drop itself, we already have a very similar behavior on Table view > Options > Fields

@charlesBochet charlesBochet added good first issue Good for newcomers ready scope: front Issues that are affecting the frontend side only and removed blocked: tech spec needed labels Apr 4, 2024
@gitstart-app GitStart App
Copy link
Contributor

gitstart-app bot commented Apr 4, 2024

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-4782

@FelixMalfait
Copy link
Member

fyi position field is already there

Screenshot 2024-04-05 at 13 26 06

@gitstart-twenty gitstart-twenty mentioned this issue Apr 17, 2024
Merged
@gitstart-app gitstart-app bot mentioned this issue Apr 19, 2024
Merged
charlesBochet pushed a commit that referenced this issue May 15, 2024
@gitstart-twenty @v1b3m
@MatheusBeniniF @FellipeMTX @FelixMalfait
AAU I want to re-order my views with drag & drop (#5002)
de228be 
### Description
I want to re-order my views with drag & drop

### Refs
#4782 

### Demo
https://jam.dev/c/699ece8a-0467-494a-b9a3-faf666ee9c93

Fixes #4782

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com>
Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitstart-twenty gitstart-twenty

Labels
good first issue Good for newcomers ready scope: front Issues that are affecting the frontend side only
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AAU I want to re-order my views with drag & drop twentyhq/twenty
5 participants
@FelixMalfait @charlesBochet @lucasbordeau @gitstart-twenty and others