Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use duplicateCompanies when saving a company entity #5259

Open
AdityaPimpalkar opened this issue May 3, 2024 · 1 comment
Open

feat: use duplicateCompanies when saving a company entity #5259

AdityaPimpalkar opened this issue May 3, 2024 · 1 comment
Assignees

Comments

@AdityaPimpalkar
Copy link
Contributor

When saving a company we need to check if we already have a company entry with a same name.

If duplicateCompanies returns more than one entry, we can give the choice to user to select the corresponding company or create new entry. If it returns a single entry, we automatically map it without giving user the choice to select

(UI/UIX on this to be decided yet - @Bonapara could you help with this? Thanks!)

@AdityaPimpalkar AdityaPimpalkar changed the title feat: use duplicateCompanies when saving a company entity scope:front size:hours feat: use duplicateCompanies when saving a company entity May 3, 2024
@FelixMalfait
Copy link
Member

I think for v1 we don't want to provide a select, let's just take first match if there are several matches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@FelixMalfait @AdityaPimpalkar and others