Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal architecture, Apple Silicon/m1 support #336

Open
romanr opened this issue Sep 2, 2023 · 2 comments
Open

Universal architecture, Apple Silicon/m1 support #336

romanr opened this issue Sep 2, 2023 · 2 comments

Comments

@romanr
Copy link

romanr commented Sep 2, 2023

Client:
N/a

Client Version:
N/a
Operating System:
N/a
Application Version:
2.8.3

Description:

Currently requires Rosetta intel cpu emulation to run.
Since Electron supports building a universal binary, would it be possible to make Electorrent support it?

image
@dingobits
Copy link

I was able to build it for arm64. I didn't dig into universal binary because it requires extra efforts and I didn't want to.

If you want to build your own, make sure you have nodejs installed with homebrew/macports first, and then follow the following commands:

git clone https://github.com/tympanix/Electorrent.git
cd Electorrent
npm install
npm run dist

You can find the arm64 binary at dist/mac-arm64/Electorrent.

@airart320
Copy link

I was able to build it for arm64. I didn't dig into universal binary because it requires extra efforts and I didn't want to.

If you want to build your own, make sure you have nodejs installed with homebrew/macports first, and then follow the following commands:

git clone https://github.com/tympanix/Electorrent.git
cd Electorrent
npm install
npm run dist

You can find the arm64 binary at dist/mac-arm64/Electorrent.

I get just the 'mac' subfolder, not the mac-arm64. Any config I miss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants