Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Types for QueryMethod inheritance and add example to docs #603

Open
hasezoey opened this issue Sep 2, 2021 · 0 comments
Open

Fix Types for QueryMethod inheritance and add example to docs #603

hasezoey opened this issue Sep 2, 2021 · 0 comments
Labels
docs This issue is about Documentation help wanted Any help would be appreciated tests This Issue is about tests | This PR is modifying tests

Comments

@hasezoey
Copy link
Member

hasezoey commented Sep 2, 2021 •
edited

As can be seen here:

typegoose/test/tests/shouldRun.test.ts

Line 478 in 8e7597d

// @ts-expect-error I (hasezoey) could not get all functions to work with each other type-wise (typegoose 9.0, mongoose 6.0, typescript 4.4)

The Types for QueryMethods with inheritance do not work correctly (runtime is fine)

Also, add documentation about QueryMethod inheritance

Note: i already tried changing the types, but i could not get it to work (tried version combination: typegoose 9.0 beta | mongoose 6.0.2 | typescript 4.4.2
@hasezoey hasezoey added help wanted Any help would be appreciated docs This issue is about Documentation tests This Issue is about tests | This PR is modifying tests labels Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs This issue is about Documentation help wanted Any help would be appreciated tests This Issue is about tests | This PR is modifying tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hasezoey