Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add "cleanup" parameter to snapshot operation #1719

Open
eliskovets opened this issue May 8, 2024 · 0 comments
Open

[Feature request] Add "cleanup" parameter to snapshot operation #1719

eliskovets opened this issue May 8, 2024 · 0 comments

Comments

@eliskovets
Copy link

eliskovets commented May 8, 2024

Description

That's not a bug, but a feature request.

It would be nice to have an additional parameter for snapshot operation that would cause the deletion of existing data in the snapshot_path directory.

Something like cleanup=true:

curl "http://localhost:8108/operations/snapshot?cleanup=true&snapshot_path=/tmp/typesense-data-snapshot" -X POST \
-H "Content-Type: application/json" \
-H "X-TYPESENSE-API-KEY: ${TYPESENSE_API_KEY}"

My case is that I don't need old snapshots and only need to keep the current. I save Typesense snapshots as EBS volume snapshots. Old Typesense snapshots in my case take extra space and I have to manage their deletion separately (on the pod level). It would be great to have such an option as a part of the Typesense snapshot operation instead.

@eliskovets eliskovets changed the title Add "remove existing" parameter to snapshot operation Add "cleanup" parameter to snapshot operation May 8, 2024
@eliskovets eliskovets changed the title Add "cleanup" parameter to snapshot operation [Feature request] Add "cleanup" parameter to snapshot operation May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant