Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case code refactoring #134

Open
Knight-X opened this issue Oct 9, 2018 · 3 comments
Open

test case code refactoring #134

Knight-X opened this issue Oct 9, 2018 · 3 comments

Comments

@Knight-X
Copy link
Member

Knight-X commented Oct 9, 2018

In order to simplify the steps of writing test case, we probably need to do some refactoring. For example, we need to run tensorflow and generate idx file manually now. I think that we can write scripts to generate data before running test case automatically.
Then, we can just compare the result between tensorflow and utensor. It will be easier to extend other test case to increase test coverage.

@mbartling
Copy link
Member

@Knight-X The only test cases that truly need IDX files are the tensor ops tests and IDX loader. These are assumed to be fixed mathematical operators with well defined behavior as a function of their inputs.

@neil-tan
Copy link
Member

neil-tan commented Oct 9, 2018

@Knight-X @mbartling @dboyliao
Guys, while we are at it, we should replace idx file with ROM_tensor.

@Knight-X
Copy link
Member Author

rom_tensor is fine. But we still need a tool to generate weight array or we have to do it manually. Compared to pushing weight files on github, I think that generating the necessary weight files before running all tests make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants