Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReluOp - template brocken since 4cb09cb8b4d0859405e30f64087b76085d227bd3 #151

Open
miki89 opened this issue Apr 14, 2019 · 5 comments
Open

Comments

@miki89
Copy link

miki89 commented Apr 14, 2019

Example from https://blog.hackster.io/simple-neural-network-on-mcus-a7cbd3dc108c does not compile any longer:
due to error:

.\models\deep_mlp.cpp:182:48: error: wrong number of template arguments (3, should be 2)
ctx.push(new ReluOp<uint8_t, float, uint8_t>(),
^
In file included from .\models\deep_mlp.cpp:8:
./uTensor/uTensor/ops/NnOps.hpp:76:7: note: provided for 'template<class T1, class TOut> class ReluOp'
class ReluOp : public Operator {
^~~~~~
.\models\deep_mlp.cpp:307:48: error: wrong number of template arguments (3, should be 2)
ctx.push(new ReluOp<uint8_t, float, uint8_t>(),
^
In file included from .\models\deep_mlp.cpp:8:
./uTensor/uTensor/ops/NnOps.hpp:76:7: note: provided for 'template<class T1, class TOut> class ReluOp'
class ReluOp : public Operator {
^~~~~~

caused, by commit of jakubvalis88 on 6 Mar commit 4cb09cb

previous commit (1c8eca4) compiles.

Please have a look.

@mbartling
Copy link
Member

Hi, I actually have a PR for this open in codegen.

uTensor/utensor_cgen#64

@miki89
Copy link
Author

miki89 commented Apr 14, 2019

Hi,
sure I understand that, but what confused me also it that the TESTS, even if deprecated and the examples show 3 arguments instead of 2.
https://github.com/uTensor/uTensor/search?q=ReluOp&unscoped_q=ReluOp

Do you also have more a stable branch, where the releases bewteen cgen and uTensor core are synced with each other?
using the develop branch might not always be the best choice.

Thank you again for commenting!

@mbartling
Copy link
Member

Yes, we use master as stable :)

@neil-tan
Copy link
Member

@miki89 I agree we should make the working combination more obvious. Perhaps, we should include the tags in the Readme?

@mbartling
Copy link
Member

The issue is we migrated the old RELU op (which was quantized) to one with "quantized" in the name for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants