Can't use element name for Binding inside a Flyout

[eriklimakc]

Current behavior

Works on Windows.

When trying to Bind a command from the Page ViewModel to a MenuFlyout that is inside an ItemTemplate using ElementName, the bind doesn't work.

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

Repro app: Flyout.zip

Workaround

No response

Works on UWP/WinUI

Yes

Environment

No response

NuGet package version(s)

"Uno.Sdk": "5.2.121"
<UnoExtensionsVersion>4.1.21</UnoExtensionsVersion>
<UnoToolkitVersion>6.0.18</UnoToolkitVersion>
<UnoThemesVersion>5.0.13</UnoThemesVersion>
<UnoCSharpMarkupVersion>5.2.14</UnoCSharpMarkupVersion>

Affected platforms

WebAssembly, Android, Skia (WPF)

IDE

Visual Studio 2022

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

[Youssef1313]

That's tricky to fix. When evaluating ElementName, we should be checking the current NameScope as well as the TemplatedParent NameScope.

Currently, we only check the current NameScope. To properly check the TemplatedParent's NameScope, we'll need #12732. Then, after this line:

uno/src/Uno.UI/DataBinding/BindingExpression.cs

Line 337 in 3c45797

var target = NameScope.FindInNamescopes(_view?.Target as DependencyObject, elementNameSubject.Name);

we should have target ??= NameScope.FindInNamescopes((_view?.Target as DependencyObject)?.TemplatedParent, elementNameSubject.Name);