Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix operator expansion #91

Merged
merged 7 commits into from Dec 15, 2016

Conversation

KingOfBrian
Copy link
Contributor

Hey @jarsen -- this PR may fix #54. It also fixes a scary bug where I thought the function had a local variable any, but it resolved as the function as type Any, which then fails to cast into anything useful. Oops.

I added some tests so this shouldn't regress.

@jarsen
Copy link
Member

jarsen commented Dec 15, 2016

@KingOfBrian Looks great, but has conflicts now. Would you mind rebasing and then I'll get his merged?

@KingOfBrian
Copy link
Contributor Author

Fixed @jarsen!

@KingOfBrian
Copy link
Contributor Author

Actually, hold on a second, I think I may have another issue 😢

@KingOfBrian
Copy link
Contributor Author

OK -- should be gtg. Thank god for merge conflicts!

@jarsen jarsen merged commit c067723 into utahiosmac:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing objects no longer works
2 participants