{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":775743011,"defaultBranch":"unstable","name":"valkey","ownerLogin":"valkey-io","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2024-03-22T00:42:17.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/164458127?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714606981.0","currentOid":""},"activityList":{"items":[{"before":"4e18e326a163211ee213b894718d61b0b936b85e","after":"72f2a8743c0dc250a184a76c377427e5ee8e6dfc","ref":"refs/heads/unstable","pushedAt":"2024-05-13T23:12:31.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"zuiderkwast","name":"Viktor Söderqvist","path":"/zuiderkwast","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/273886?s=80&v=4"},"commit":{"message":"Minor fix in module API doc script (#494)\n\nThe script extracts the comments and prototypes from module.c and does\r\nsome pre-processing, e.g. converts URLs to markdown links. The URL\r\nregexp didn't account for '#', '?' (and a few more chars) so an URL like\r\n`https://example.com/#section` was converted to markdown as\r\n\r\n [https://example.com/](https://example.com/)#section\r\n\r\nWith this change, it's instead correctly converted to\r\n\r\n [https://example.com/#section](https://example.com/#section)\r\n\r\nAdditional change: Removes an unused metadata field.\r\n\r\nSigned-off-by: Viktor Söderqvist ","shortMessageHtmlLink":"Minor fix in module API doc script (#494)"}},{"before":"c7ad9feb52973da8ba7d49b5530837466a910477","after":"4e18e326a163211ee213b894718d61b0b936b85e","ref":"refs/heads/unstable","pushedAt":"2024-05-13T03:02:42.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"enjoy-binbin","name":"Binbin","path":"/enjoy-binbin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22811481?s=80&v=4"},"commit":{"message":"Remove endian coverage from server.c (#492)\n\nIn https://github.com/valkey-io/valkey/commit/c7ad9feb52973da8ba7d49b5530837466a910477,\r\nwe missed removed endian coverage from the legacy unit tests, so it failed to find it when building.\r\n\r\nSigned-off-by: Madelyn Olson ","shortMessageHtmlLink":"Remove endian coverage from server.c (#492)"}},{"before":"dca17223406f15a42fc363333847721f3647eac7","after":"c7ad9feb52973da8ba7d49b5530837466a910477","ref":"refs/heads/unstable","pushedAt":"2024-05-12T23:58:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Migrate endianconv.c unit tests to new test framework (#458)\n\nThis PR migrates all tests related to endianconv into new test framework\r\nas part of the parent issue https://github.com/valkey-io/valkey/issues/428.\r\n\r\n---------\r\n\r\nSigned-off-by: Karthick Ariyaratnam \r\nSigned-off-by: Madelyn Olson \r\nCo-authored-by: Madelyn Olson ","shortMessageHtmlLink":"Migrate endianconv.c unit tests to new test framework (#458)"}},{"before":"ac47ca2d47ef3a26b323571106a1438d1b812cd4","after":"dca17223406f15a42fc363333847721f3647eac7","ref":"refs/heads/unstable","pushedAt":"2024-05-12T23:29:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Use kqueue as the backend of AE on DragonFlyBSD (#450)\n\nCurrently, we use select(2) on DragonFlyBSD while\r\n`kqueue` is available on DragonFlyBSD since FreeBSD 4.1\r\nand DragonFlyBSD was originally forked from FreeBSD 4.8\r\n\r\n`select(2)` is a pretty old technique that has many defects\r\ncompared to `kqueue`, we should switch to `kqueue` on DragonFlyBSD.\r\n\r\nSigned-off-by: Andy Pan ","shortMessageHtmlLink":"Use kqueue as the backend of AE on DragonFlyBSD (#450)"}},{"before":"07367df981722fc021e9ac1b5d27e03af5618291","after":"ac47ca2d47ef3a26b323571106a1438d1b812cd4","ref":"refs/heads/unstable","pushedAt":"2024-05-12T23:08:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Suppress ASAN errors on tests that intentially crash the server via `crash-memcheck-enabled no` (#489)\n\nFix daily CI run errors like\r\nhttps://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176\r\n\r\nSigned-off-by: Ping Xie ","shortMessageHtmlLink":"Suppress ASAN errors on tests that intentially crash the server via `…"}},{"before":"e242799867af8e4048920494806b2f40d43c86f5","after":"07367df981722fc021e9ac1b5d27e03af5618291","ref":"refs/heads/unstable","pushedAt":"2024-05-10T19:51:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"zuiderkwast","name":"Viktor Söderqvist","path":"/zuiderkwast","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/273886?s=80&v=4"},"commit":{"message":"Update rdb and module's child proc name to valkey accordingly (compatible with redis symlink) (#454)\n\nIf `valkey-server` was started with the `redis-server` symlink, the old\r\nproc names are used, for backwards compatibility.\r\n\r\n---------\r\n\r\nSigned-off-by: Shivshankar-Reddy ","shortMessageHtmlLink":"Update rdb and module's child proc name to valkey accordingly (compat…"}},{"before":"138a7d9846c9c8216541a928c4494645731cb658","after":"e242799867af8e4048920494806b2f40d43c86f5","ref":"refs/heads/unstable","pushedAt":"2024-05-10T02:44:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Migrate sha1 unit test to new framework (#470)\n\nThis migrates unit tests related to sha1 to new framework, ref: #428.\r\n\r\n---------\r\n\r\nSigned-off-by: Shivshankar-Reddy \r\nSigned-off-by: Madelyn Olson \r\nCo-authored-by: Madelyn Olson ","shortMessageHtmlLink":"Migrate sha1 unit test to new framework (#470)"}},{"before":"8048abb2fd10ad66199c8f03bb543b0ec67bc966","after":"138a7d9846c9c8216541a928c4494645731cb658","ref":"refs/heads/unstable","pushedAt":"2024-05-10T01:12:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"PingXie","name":"Ping Xie","path":"/PingXie","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11568491?s=80&v=4"},"commit":{"message":" Handle role change error in `cluster setslot` when migrating the last slot away with allow-replica-migration enabled (#466)","shortMessageHtmlLink":" Handle role change error in cluster setslot when migrating the las…"}},{"before":"0342a81b7c20d8a5360b18ef751c299e7303caf2","after":"8048abb2fd10ad66199c8f03bb543b0ec67bc966","ref":"refs/heads/unstable","pushedAt":"2024-05-10T00:30:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"zuiderkwast","name":"Viktor Söderqvist","path":"/zuiderkwast","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/273886?s=80&v=4"},"commit":{"message":"Support pipe2() on *BSD (#462)\n\nBefore this PR, `pipe2()` is only enabled on Linux and FreeBSD while\r\n`pipe2()` is available on *BSD.\r\n\r\nThis PR enables `pipe2()` for the rest of *BSD: DragonFlyBSD, NetBSD and\r\nOpenBSD.\r\n\r\n## References\r\n\r\n- [pipe2 on\r\nDraonFlyBSD](https://man.dragonflybsd.org/?command=pipe§ion=2)\r\n- [__DragonFly_version for\r\npipe2](https://github.com/DragonFlyBSD/DragonFlyBSD/blob/7485684fa5c3fadb6c7a1da0d8bb6ea5da4e0f2f/sys/sys/param.h#L121)\r\n- [pipe2 on NetBSD](https://man.netbsd.org/pipe.2)\r\n- [pipe2 on OpenBSD](https://man.openbsd.org/pipe.2)\r\n\r\nSigned-off-by: Andy Pan ","shortMessageHtmlLink":"Support pipe2() on *BSD (#462)"}},{"before":"4e1d8e17212bbf074bfc4d8bb8c9e6ab9818d5d1","after":"0342a81b7c20d8a5360b18ef751c299e7303caf2","ref":"refs/heads/unstable","pushedAt":"2024-05-09T21:54:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Migrate sds.c unit tests to new test framework. (#478)\n\nThis patch migrates all tests in sds.c into new test framework as part\r\nof the parent issue https://github.com/valkey-io/valkey/issues/428.\r\n\r\n---------\r\n\r\nSigned-off-by: Lipeng Zhu \r\nSigned-off-by: Madelyn Olson \r\nCo-authored-by: Madelyn Olson ","shortMessageHtmlLink":"Migrate sds.c unit tests to new test framework. (#478)"}},{"before":"2559f64f5a67ad09037893ba10a7a6067a826f51","after":"4e1d8e17212bbf074bfc4d8bb8c9e6ab9818d5d1","ref":"refs/heads/unstable","pushedAt":"2024-05-09T21:29:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"[Fix] move deps from slowlog.c into slowlog.h (#465)\n\nMove dependency from `slowlog.c` into `slowlog.h`, make sure the\r\nlanguage server can work properly under `slowlog.h`\r\n\r\nSigned-off-by: arthur.lee ","shortMessageHtmlLink":"[Fix] move deps from slowlog.c into slowlog.h (#465)"}},{"before":"b166980c8e6618a66aa0ec82e77c40bb305404be","after":"2559f64f5a67ad09037893ba10a7a6067a826f51","ref":"refs/heads/unstable","pushedAt":"2024-05-09T21:26:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"[FIX] Remove redundant statement and return (#481)\n\n* `freeClientArgv` was previously defined in `server.h`\r\n* remove the redundant return\r\n\r\nSigned-off-by: arthur.lee ","shortMessageHtmlLink":"[FIX] Remove redundant statement and return (#481)"}},{"before":"fdd023ff8239ded21998fc711362759e0ca68bcc","after":"b166980c8e6618a66aa0ec82e77c40bb305404be","ref":"refs/heads/unstable","pushedAt":"2024-05-09T21:26:15.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Fix UNUSED repetition issue in test sources (#475)\n\nThis is a follow-up PR to address UNUSED repetition issue (see\r\nhttps://github.com/valkey-io/valkey/pull/446#discussion_r1593204956) in\r\ndifferent test source files.\r\n\r\nSigned-off-by: Karthick Ariyaratnam ","shortMessageHtmlLink":"Fix UNUSED repetition issue in test sources (#475)"}},{"before":"6cff0d6a7b52c36915fbf70c416998e4eb789fcd","after":"fdd023ff8239ded21998fc711362759e0ca68bcc","ref":"refs/heads/unstable","pushedAt":"2024-05-09T02:14:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"enjoy-binbin","name":"Binbin","path":"/enjoy-binbin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22811481?s=80&v=4"},"commit":{"message":"Migrate cluster mode tests to normal framework (#442)\n\nWe currently has two disjoint TCL frameworks:\r\n1. Normal testing framework, which trigger by runtest, which individually\r\nlaunches nodes for testing.\r\n2. Cluster framework, which trigger by runtest-cluster, which pre-allocates\r\nN nodes and uses them for testing large configurations.\r\n\r\nThe normal TCL testing framework is much more readily tested and is also\r\nautomatically run as part of the CI for new PRs. The runtest-cluster since\r\nit runs very slowly (cannot be parallelized), it currently only runs in daily\r\nCI, this results in some changes to the cluster not being exposed in PR CI\r\nin time.\r\n\r\nThis PR migrate the Cluster mode tests to normal framework. Some cluster\r\ntests are kept in runtest-cluster because of timing issues or not yet\r\nsupported, we can process them later.\r\n\r\nSigned-off-by: Binbin ","shortMessageHtmlLink":"Migrate cluster mode tests to normal framework (#442)"}},{"before":"1125bdbb805f3467e8f01e223870fdd1918f12f6","after":"6cff0d6a7b52c36915fbf70c416998e4eb789fcd","ref":"refs/heads/unstable","pushedAt":"2024-05-08T19:38:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Remove intsettest declaration from intset.h (#471)\n\nAll the intset unit tests are migrated to new test framework as part of\r\nhttps://github.com/valkey-io/valkey/pull/344, but the old framework\r\ndeclaration is missed to remove from intset.h. So removed the code.\r\n\r\nSigned-off-by: Shivshankar-Reddy ","shortMessageHtmlLink":"Remove intsettest declaration from intset.h (#471)"}},{"before":"6af51f5092785f2367b4d86e3152db132b26b140","after":"1125bdbb805f3467e8f01e223870fdd1918f12f6","ref":"refs/heads/unstable","pushedAt":"2024-05-08T19:17:32.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Update serverpanic output based on 'extended-redis-compatibility' config. (#415)\n\nUpdated serverPanic output in db.c based on the\r\nextended-redis-compatibility config. and also updated comments in other\r\nfiles.\r\n\r\n---------\r\n\r\nSigned-off-by: Shivshankar-Reddy ","shortMessageHtmlLink":"Update serverpanic output based on 'extended-redis-compatibility' con…"}},{"before":"2278dfd253fdae5a42171fa3bea9e14c06bc3dd1","after":"6af51f5092785f2367b4d86e3152db132b26b140","ref":"refs/heads/unstable","pushedAt":"2024-05-08T18:58:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"zuiderkwast","name":"Viktor Söderqvist","path":"/zuiderkwast","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/273886?s=80&v=4"},"commit":{"message":"Prevent clang-format in certain places (#468)\n\nThis is a preparation for adding clang-format.\r\n\r\nThese comments prevent automatic formatting in some places. With these\r\nexceptions, we will be able to run clang-format on the rest of the code.\r\n\r\nThis is a preparation for #323.\r\n\r\n---------\r\n\r\nSigned-off-by: Viktor Söderqvist ","shortMessageHtmlLink":"Prevent clang-format in certain places (#468)"}},{"before":"315b7573c423a6cddf0a63aba364c57917697756","after":"2278dfd253fdae5a42171fa3bea9e14c06bc3dd1","ref":"refs/heads/unstable","pushedAt":"2024-05-08T18:52:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hwware","name":"Wen Hui","path":"/hwware","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/51993843?s=80&v=4"},"commit":{"message":"Fix build error for unit test (#473)\n\nFix the compile error with the following command:\r\n`make all-with-unit-tests SERVER_CFLAGS='-Werror -DSERVER_TEST'\r\n`\r\n\r\n```\r\n/usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1172: undefined reference to `lua_next'\r\n/usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1154: undefined reference to `lua_toboolean'\r\n/usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1175: undefined reference to `lua_type'\r\n/usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1176: undefined reference to `lua_tonumber'\r\ncollect2: error: ld returned 1 exit status\r\nmake[1]: *** [Makefile:469: valkey-unit-tests] Error 1\r\nmake[1]: Leaving directory '/home/ubuntu/valkey-shiv-repo/valkey/src'\r\nmake: *** [Makefile:6: all-with-unit-tests] Error 2\r\n```\r\n\r\nIssue is happened as all deps libraries not linked for\r\nvalkey-unit-tests, so linked all libraries to the binary.\r\n\r\nSigned-off-by: Shivshankar-Reddy ","shortMessageHtmlLink":"Fix build error for unit test (#473)"}},{"before":"4e944cedeeec209e282f01c75662865530270fb5","after":"315b7573c423a6cddf0a63aba364c57917697756","ref":"refs/heads/unstable","pushedAt":"2024-05-08T13:44:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"hwware","name":"Wen Hui","path":"/hwware","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/51993843?s=80&v=4"},"commit":{"message":"Update server function's name to valkey (#456)\n\nUpdated valkey in follwing functions.\r\n\r\ngenRedisInfoString -> genValkeyInfoString\r\ngenRedisInfoStringCommandStats -> genValkeyInfoStringCommandStats\r\ngenRedisInfoStringACLStats -> genValkeyInfoStringACLStats\r\ngenRedisInfoStringLatencyStats -> genValkeyInfoStringLatencyStats\r\n\r\nSigned-off-by: Shivshankar-Reddy ","shortMessageHtmlLink":"Update server function's name to valkey (#456)"}},{"before":"1aca85e3deb53be46ae24c671a138c7d92e1990f","after":"4e944cedeeec209e282f01c75662865530270fb5","ref":"refs/heads/unstable","pushedAt":"2024-05-07T23:49:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Migrate kvstore.c unit tests to new test framework. (#446)\n\nThis PR migrates all tests related to kvstore into new test framework as\r\npart of the parent issue https://github.com/valkey-io/valkey/issues/428.\r\n\r\n---------\r\n\r\nSigned-off-by: Karthick Ariyaratnam \r\nSigned-off-by: Madelyn Olson \r\nCo-authored-by: Madelyn Olson ","shortMessageHtmlLink":"Migrate kvstore.c unit tests to new test framework. (#446)"}},{"before":"2ed71de8e17dd5b9206acd9b40425f99c45dbcff","after":"1aca85e3deb53be46ae24c671a138c7d92e1990f","ref":"refs/heads/unstable","pushedAt":"2024-05-07T23:29:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Update module api and variable to valkey accordingly. (#455)\n\nUpdated redis instances accordingly as follows.\r\nrediscmd -> serverCmd\r\nfreeRedisModuleAsyncRMCallPromise -> freeValkeyModuleAsyncRMCallPromise\r\nMyCommand_RedisCommand -> MyCommand_ValkeyCommand\r\nRedisModuleString -> ValkeyModuleString\r\nflushRedisModuleIOBuffer -> flushValkeyModuleIOBuffer\r\n\r\nSigned-off-by: Shivshankar-Reddy ","shortMessageHtmlLink":"Update module api and variable to valkey accordingly. (#455)"}},{"before":"cde8ec1b414e5da00ee90cbaf21c1c7ae37e93e9","after":"2ed71de8e17dd5b9206acd9b40425f99c45dbcff","ref":"refs/heads/unstable","pushedAt":"2024-05-07T23:21:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Migrate util.c unit tests to new test framework (#448)\n\nThis PR migrates all tests related to util into new test framework as\r\npart of the parent issue https://github.com/valkey-io/valkey/issues/428.\r\n\r\n---------\r\n\r\nSigned-off-by: Karthick Ariyaratnam ","shortMessageHtmlLink":"Migrate util.c unit tests to new test framework (#448)"}},{"before":"ba9dd7b23a13452cf4aac1420ecffcbab879fbe3","after":"cde8ec1b414e5da00ee90cbaf21c1c7ae37e93e9","ref":"refs/heads/unstable","pushedAt":"2024-05-07T17:25:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"zuiderkwast","name":"Viktor Söderqvist","path":"/zuiderkwast","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/273886?s=80&v=4"},"commit":{"message":"Don't try to set SO_REUSEADDR on sockets of AF_UNIX (#451)\n\nDespite the fact that SO_REUSEADDR can be set on a Unix domain socket\r\nvia setsockopt() without reporting an error, SO_REUSEADDR was actually\r\ncreated for ipv4/ipv6 and it's not supported for sockets of AF_UNIX.\r\n\r\nTherefore, setting this option on a Unix domain socket does nothing but\r\ncosts one extra system call.\r\n\r\nSigned-off-by: Andy Pan ","shortMessageHtmlLink":"Don't try to set SO_REUSEADDR on sockets of AF_UNIX (#451)"}},{"before":"6e7af9471c0576e9567b62821b23aa13edf4e866","after":"ba9dd7b23a13452cf4aac1420ecffcbab879fbe3","ref":"refs/heads/unstable","pushedAt":"2024-05-07T06:39:29.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"soloestoy","name":"zhaozhao.zz","path":"/soloestoy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24804835?s=80&v=4"},"commit":{"message":"Add noscores option to command ZSCAN. (#324)\n\nCommand syntax is now:\r\n```\r\nZSCAN key cursor [MATCH pattern] [COUNT count] [NOSCORES]\r\n```\r\nReturn format:\r\n```\r\n127.0.0.1:6379> zadd z 1 a 2 b 3 c\r\n(integer) 3\r\n127.0.0.1:6379> zscan z 0\r\n1) \"0\"\r\n2) 1) \"a\"\r\n 2) \"1\"\r\n 3) \"b\"\r\n 4) \"2\"\r\n 5) \"c\"\r\n 6) \"3\"\r\n127.0.0.1:6379> zscan z 0 noscores\r\n1) \"0\"\r\n2) 1) \"a\"\r\n 2) \"b\"\r\n 3) \"c\"\r\n```\r\nwhen NOSCORES is on, the command will only return members in the zset,\r\nwithout scores.\r\n\r\nFor client side parsing the command return, I believe it is fine as long\r\nas the command is backwards compatible. The return structure are still\r\nlists, what has changed is the content. And clients can tell the\r\ndifference by the subcommand they use.\r\n\r\nSince `novalues` option of `HSCAN` is already accepted\r\n(redis/redis#12765), I think similar thing can be done to `ZSCAN`.\r\n\r\n---------\r\n\r\nSigned-off-by: Chen Tianjie ","shortMessageHtmlLink":"Add noscores option to command ZSCAN. (#324)"}},{"before":"e2aec3b1a2e15e842e60b1e6f9210766c012f3a1","after":"6e7af9471c0576e9567b62821b23aa13edf4e866","ref":"refs/heads/unstable","pushedAt":"2024-05-07T04:40:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"PingXie","name":"Ping Xie","path":"/PingXie","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11568491?s=80&v=4"},"commit":{"message":"Slot migration improvement (#445)","shortMessageHtmlLink":"Slot migration improvement (#445)"}},{"before":"93f8a19b6f9884f382d24f7650822d99cbb26c6d","after":"e2aec3b1a2e15e842e60b1e6f9210766c012f3a1","ref":"refs/heads/unstable","pushedAt":"2024-05-07T01:34:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Fix an error in unit/README (#447)\n\nThis PR fixes an error in the unit/READMED.md (see\r\nhttps://github.com/valkey-io/valkey/issues/428) in order to correct the\r\nsteps for running single unit test file.\r\n\r\nSigned-off-by: Karthick Ariyaratnam ","shortMessageHtmlLink":"Fix an error in unit/README (#447)"}},{"before":"1b3199e0705817e2cdd8bca6ce3ab3b3567b4573","after":"93f8a19b6f9884f382d24f7650822d99cbb26c6d","ref":"refs/heads/unstable","pushedAt":"2024-05-06T07:09:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"PingXie","name":"Ping Xie","path":"/PingXie","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11568491?s=80&v=4"},"commit":{"message":"Change strlcat function name from redis to valkey (#440)\n\nUpdated strlcat function and macros name (redis_strlcat ->\r\nvalkey_strlcat).\r\n\r\nI think the standard strcat function is not safe.\r\n(https://codeql.github.com/codeql-query-help/cpp/cpp-unsafe-strcat/)\r\nSo, it would be better to keep it as a safe function.\r\n\r\nSigned-off-by: NAM UK KIM ","shortMessageHtmlLink":"Change strlcat function name from redis to valkey (#440)"}},{"before":"cc703aa3bcb866dfda6ca9bf6ca527ce6cc44ad9","after":"1b3199e0705817e2cdd8bca6ce3ab3b3567b4573","ref":"refs/heads/unstable","pushedAt":"2024-05-06T05:00:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Fix unit test issues on address sanitizer and fortify (#437)\n\nThis commit does four things:\r\n\r\n1. On various images, the linker was not able to correctly load the flto\r\noptimizations from the archive generated for unit tests, and was\r\nthrowing errors. I was able to solve this by updating the plugin for the\r\nfortify test, but was unable to reproduce it on the ASAN tests or find a\r\nsolution. So I decided to go with a single solution for now, which was\r\nto just disable the linker optimizations for those tests. This shouldn't\r\nweaken the protections provided by ASAN.\r\n2. The change to remove flto for some reason caused some odd inlining\r\nbehavior in the intset test, that I wasn't really able to understand.\r\nThe error was basically that we were doing a 4 byte write, starting at\r\nbyte offset 8, for the first addition to listpack that was of size 10.\r\nPractically this has no effect, since I'm not aware of any allocator\r\nthat would give us a 10 byte block as opposed to 12 (or more likely 16)\r\nbytes. The isn't the correct behavior, since an uninitialized listpack\r\ndefaults to 16bit encoding, which should only be writing 2 bytes. I\r\nrabbit holed like 2 hours into this, and gave up and just ignored the\r\nwarning on the file.\r\n3. Now that address sanitizer was correctly running, it picked up two\r\nissues. A memory leak and uninitialized value, so those were easy to\r\nfix.\r\n4. There is also a small change to the fortify to build the test up\r\nfront instead of later, this is just to be consistent with other tests\r\nand has no functional change.\r\n\r\nSigned-off-by: Madelyn Olson ","shortMessageHtmlLink":"Fix unit test issues on address sanitizer and fortify (#437)"}},{"before":"9ebbd5f03856ba8b6472aaf88712459a2e4d00b5","after":"cc703aa3bcb866dfda6ca9bf6ca527ce6cc44ad9","ref":"refs/heads/unstable","pushedAt":"2024-05-06T04:52:59.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Input output traffic stats and command process count for each client. (#327)\n\nWe already have global stats for input traffic, output traffic and how\r\nmany commands have been executed.\r\n\r\nHowever, some users have the difficulty of locating the IP(s) which have\r\nheavy network traffic. So here some stats for single client are\r\nintroduced.\r\n``` \r\ntot-net-in // Total network input bytes read from the client\r\ntot-net-out // Total network output bytes sent to the client\r\ntot-cmds // Total commands the client has executed \r\n``` \r\nThese three stats are shown in `CLIENT LIST` and `CLIENT INFO`.\r\n\r\nThough the metrics are handled in hot paths of the code, personally I\r\ndon't think it will slow down the server. Considering all other complex\r\noperations handled nearby, this is only a small and simple operation.\r\n\r\nHowever we do need to be cautious when adding more and more metrics, as\r\ndiscussed in redis/redis#12640, we may need to find a way to tell\r\nwhether this has obvious performance degradation.\r\n\r\n---------\r\n\r\nSigned-off-by: Chen Tianjie ","shortMessageHtmlLink":"Input output traffic stats and command process count for each client. (…"}},{"before":"39d4b43d4beba0b656929a09d48ade662f52edf9","after":"9ebbd5f03856ba8b6472aaf88712459a2e4d00b5","ref":"refs/heads/unstable","pushedAt":"2024-05-04T19:38:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"madolson","name":"Madelyn Olson","path":"/madolson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34459052?s=80&v=4"},"commit":{"message":"Fix issues for older versions of Darwin and improve PowerPC support (#436)\n\nExisting code does not build on macOS < 10.7. There are two issues:\r\n1. The check for `MAC_OS_10_6_DETECTED` does the opposite of what it\r\nshould, since `AvailabilityMacros.h` does not define underscore-prefixed\r\nversions of macros. `__MAC_OS_X_VERSION_MAX_ALLOWED` evaluates to 0, and\r\non 10.6 everything breaks down:\r\n\r\nCredits to @mohd-akram who pointed out at possible origin of the this\r\nproblem.\r\n\r\n2. Once that is fixed, on 10.6 when building for `ppc` there are new\r\nerrors, because the code uses inaccurate assumptions for archs. Fix that\r\ntoo.\r\n\r\n---------\r\n\r\nSigned-off-by: Sergey Fedorov ","shortMessageHtmlLink":"Fix issues for older versions of Darwin and improve PowerPC support (#…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAESObB4AA","startCursor":null,"endCursor":null}},"title":"Activity · valkey-io/valkey"}