New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing trademarks from sentinel code #269
Comments
It's not "nearly identical". It is the hiredis functions. Sentinel is using hiredis. Since we have decided to not change deps/hiredis code, we shall also keep the calls to these functions. (If we later decide to replace hiredis with a fork of hiredis, we can change all of this, but not now.)
OK, sounds good. |
The Is that what you intended? If so, please consider this comment found in sentinel.c:
Also, these functions are all |
Wow, this is more complicated than I thought. 😁 I suggest you just leave them as redis. Then the comment you quoted will still be correct. |
I started on removing trademarks on the sentinel code (see #268 ) but it seems that both of the simple rules
redis -> server
andredis -> valkey
might be rejected, so that I would have to do things twice or even three times. This issue is being opened so that we can discuss what you would like to see.There may be objections to
redis -> server
on the grounds that this is in sentinel, not the server.redis -> sentinel
seems better to me, but looks a bit strange in tls.c.redis -> valkey
seems to be legal and safe everywhere in sentinel.c and tls.c.Sentinel uses code that also appears in both hiredis and the server. There are many structures and functions (e.g., redisAeAddRead) that are nearly identical in both sentinel.c and hiredis. For the objects that are static in sentinel.c, I prefer
redis -> sentinel
.I would rename
sentinelRedisInstance
tosentinelValkeyInstance
and rename theSRI
abbreviation toSVI
.The text was updated successfully, but these errors were encountered: