Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RedisEnterpriseCommandFlags for Valkey #17

Open
dmitrypol opened this issue May 2, 2024 · 3 comments
Open

Remove RedisEnterpriseCommandFlags for Valkey #17

dmitrypol opened this issue May 2, 2024 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@dmitrypol
Copy link
Collaborator

in commands.rs

#[derive(Debug, Deserialize)]
pub enum RedisEnterpriseCommandFlags {
    /// A special enterprise only flag, make sure the commands marked with this flag will not be expose to
    /// user via `command` command or on slow log.
    ProxyFiltered,
}

impl From<&RedisEnterpriseCommandFlags> for &'static str {
    fn from(value: &RedisEnterpriseCommandFlags) -> Self {
        match value {
            RedisEnterpriseCommandFlags::ProxyFiltered => "_proxy-filtered",
        }
    }
}
@dmitrypol dmitrypol self-assigned this May 2, 2024
@dmitrypol
Copy link
Collaborator Author

@madolson @PingXie - you guys OK with this? I can easily make the change.

@dmitrypol dmitrypol changed the title Remove RedisEnterpriseCommandFlags Remove RedisEnterpriseCommandFlags for Valkey May 2, 2024
@PingXie
Copy link
Member

PingXie commented May 2, 2024

I think we should remove it. The obvious branding issue aside, it also makes no sense to reference an architectural decision (proxy) that is not in the Valkey scope.

@dmitrypol dmitrypol added the question Further information is requested label May 2, 2024
@madolson
Copy link
Member

madolson commented May 3, 2024

I agree, let's remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants