Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate file reading from Foundation #39

Open
Joannis opened this issue Jan 16, 2018 · 1 comment
Open

Separate file reading from Foundation #39

Joannis opened this issue Jan 16, 2018 · 1 comment
Labels
enhancement
Milestone
1.0

Comments

@Joannis
Copy link
Contributor

Joannis commented Jan 16, 2018 •
edited

File is dependent on Foundation file reading which is blocking and dependent on this line of code which as of today is known to cause infinite loops on 0 length files
@vzsg
Copy link
Member

vzsg commented Jan 16, 2018

Zero-byte files are not the issue, but reading virtual files (like procfs, sysfs) where stat returns an arbitrary file size (typ. 4096), but read can only read a few bytes before EOF. That Foundation function doesn't handle premature EOF at all.

@tanner0101 tanner0101 added this to the 1.0 milestone Jan 23, 2018
@tanner0101 tanner0101 assigned tanner0101 and Joannis and unassigned tanner0101 Jan 23, 2018
@Joannis Joannis mentioned this issue Feb 1, 2018
Open
@tanner0101 tanner0101 added this to Todo in Vapor 3 Feb 12, 2018
@tanner0101 tanner0101 removed this from Todo in Vapor 3 Mar 21, 2018
@Joannis Joannis removed their assignment Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
1.0
Development

No branches or pull requests
3 participants
@tanner0101 @vzsg @Joannis