You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The updated MolliePlugin that re-uses existing mollie orders rather than creating new ones can cause erroneous charges by not re-using or cancelling order lines correctly. While beneficial to the shop owner unless the customer notices, I do not think this is intentional.
To Reproduce
Steps to reproduce the behavior:
Go to mollie checkout (in our storefront: AddingItems -> ArrangingPayment, then create intent)
Return from mollie checkout again (in our storefront: ArrangingPayment -> AddingItems)
Go to mollie checkout again (in our storefront: AddingItems -> ArrangingPayment, then create intent)
See error
Expected behavior
Only order line items present in the vendure order end up being present in the mollie order.
Environment (please complete the following information):
If the order lines are equal, the first condition is not met and they will be pushed again into the mollie order by using the add operation, while old order lines are still present. I think for safety reasons it might make sense to simply cancel all old lines and then create new ones rather than to mess with re-using the existing lines, but that is just my gut feeling.
The text was updated successfully, but these errors were encountered:
Describe the bug
The updated MolliePlugin that re-uses existing mollie orders rather than creating new ones can cause erroneous charges by not re-using or cancelling order lines correctly. While beneficial to the shop owner unless the customer notices, I do not think this is intentional.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Only order line items present in the vendure order end up being present in the mollie order.
Environment (please complete the following information):
Additional context
I haven't debugged the issue but I believe it might stem from here https://github.com/vendure-ecommerce/vendure/blob/7d50b5446d823f933103442ac6ce99f5bd02e5b6/packages/payments-plugin/src/mollie/mollie.service.ts#L486C13-L492C14
If the order lines are equal, the first condition is not met and they will be pushed again into the mollie order by using the add operation, while old order lines are still present. I think for safety reasons it might make sense to simply cancel all old lines and then create new ones rather than to mess with re-using the existing lines, but that is just my gut feeling.
The text was updated successfully, but these errors were encountered: