Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor baseUrl to fix exposing NEXT_PUBLIC_VERCEL_URL #1326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor baseUrl to fix exposing NEXT_PUBLIC_VERCEL_URL #1326

wants to merge 1 commit into from

Conversation

valiant1x
Copy link

@valiant1x valiant1x commented Apr 17, 2024 •
edited

Description

  • NEXT_PUBLIC_VERCEL_URL is a long, internal looking domain that points to something like https://my-cool-name-h2134yh2-github-user-projects.vercel.app/. this ends up in robots.txt, sitemap, and the opengraph image URLs as part of the current app configuration, assuming you deploy with Vercel
  • the README and setup requirements already stipulate that TWITTER_URL points to the prod domain, so let's reuse that!
  • this PR refactors baseUrl to a global constant that considers vercel prod env and existing env var for prod URL (TWITTER_SITE)

fixes #1324

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024

@valiant1x is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@danieldanielecki
Copy link

@leerob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sitemap.xml & robots.txt points to Vercel's domain
2 participants
@valiant1x @danieldanielecki