Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick the protocol from the url if provided #364

Open
pmlopes opened this issue Feb 16, 2023 · 1 comment
Open

Pick the protocol from the url if provided #364

pmlopes opened this issue Feb 16, 2023 · 1 comment

Comments

@pmlopes
Copy link
Member

pmlopes commented Feb 16, 2023

Currently, the client negotiates the protocol version at connection level, or falls back to 2 if configured so.

Instead, we could pick it from the url if provided, as it is now a reserved property.

redis/redis-specifications#12 (review)

@Ladicek
Copy link
Contributor

Ladicek commented Mar 13, 2024

I wish I noticed this issue sooner, I would have used the protocol param instead of adding an extra method in #422. Oh well. Maybe we can do both? 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants