Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config-site/surface86.cmake #19487

Closed
markcmiller86 opened this issue May 3, 2024 · 8 comments · Fixed by #19515
Closed

Remove config-site/surface86.cmake #19487

markcmiller86 opened this issue May 3, 2024 · 8 comments · Fixed by #19515
Labels
bug Something isn't working good first issue Good for newcomers impact low Productivity trivially degraded (easily mitigated bug) or improved (enhancment) likelihood low Occurrence/expected use specific to data, operators, configuration, etc. or combinations thereof low-hanging fruit A cognizant developer has a shot at resolving in <1/2 day of work

Comments

@markcmiller86
Copy link
Member

No description provided.

@markcmiller86 markcmiller86 added bug Something isn't working good first issue Good for newcomers likelihood low Occurrence/expected use specific to data, operators, configuration, etc. or combinations thereof impact low Productivity trivially degraded (easily mitigated bug) or improved (enhancment) low-hanging fruit A cognizant developer has a shot at resolving in <1/2 day of work labels May 3, 2024
@JustinPrivitera
Copy link
Member

Also can remove justin-IdeaPad-L340-17IRH-Gaming.cmake

@JustinPrivitera
Copy link
Member

JustinPrivitera commented May 3, 2024

and rztopaz194.cmake
Should make sure symlinks to rztopaz are replaced.
#19492

@lukemurphy147
Copy link
Contributor

Hi, I'm new to open-source, and I got here from https://goodfirstissues.com/. May I please work on this issue?

@markcmiller86
Copy link
Member Author

@lukemurphy147 ... certainly.

That said, being new to open source, I might not select the VisIt project as your first foray. Its a pretty complex software project with a lot of process to follow...probably more than you want to be exposed to initially. There are probably many other simpler projects with simpler contribution workflows that might be better to start with.

If you do decide to proceed, please do your work on the 3.4RC branch. Please start by reading and following the instructions for working with GitHub.

@JustinPrivitera
Copy link
Member

JustinPrivitera commented May 3, 2024

If you do work on this, you may want to skip deleting rztopaz194.cmake, since we ought to deliberate a bit about its fate, and the fate of the symlinks to it.

@lukemurphy147
Copy link
Contributor

lukemurphy147 commented May 4, 2024

-snip-
If you do decide to proceed, please do your work on the 3.4RC branch. Please start by reading and following the instructions for working with GitHub.

I don't know how to find that branch, and that link is dead.
EDIT: Never mind, I found the list of branches.

@JustinPrivitera
Copy link
Member

I don't know how to find that branch, and that link is dead.

Link works for me.

lukemurphy147 pushed a commit to lukemurphy147/visit that referenced this issue May 4, 2024
@markcmiller86
Copy link
Member Author

There was a small period of time last night were our docs on ReadTheDocs were down. I was debugging issues with doc builds and created a problem there that I corrected within 10-15 mins. So, if you were unlucky and tried to follow the link then, that may have been the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers impact low Productivity trivially degraded (easily mitigated bug) or improved (enhancment) likelihood low Occurrence/expected use specific to data, operators, configuration, etc. or combinations thereof low-hanging fruit A cognizant developer has a shot at resolving in <1/2 day of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants