Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not draw plot marker if the value is 0 #156

Open
KleinK0910 opened this issue Feb 7, 2023 · 3 comments
Open

Do not draw plot marker if the value is 0 #156

KleinK0910 opened this issue Feb 7, 2023 · 3 comments

Comments

@KleinK0910
Copy link
Member

Screenshot 2023-02-07 at 15 25 17

On the attached screenshot of an example, the first three rows have 0 (or empty) values in all years, but the markers still appear.

@simzer simzer self-assigned this Sep 13, 2023
@simzer
Copy link
Member

simzer commented Sep 23, 2023

Zero height markers are drawn with zero height. They can only be seen because all markers have an 1px border on barchart by default. Setting the linewidth to 0, a the bars with 0 height disappear: https://jsfiddle.net/simzer/x63umje8/2/

@simzer
Copy link
Member

simzer commented Sep 25, 2023

Workaround:

  style: {
  	plot: {
      marker: {
        borderOpacityMode: 'straight',
        borderOpacity: 0
      }
    }
  }

@simzer
Copy link
Member

simzer commented Sep 25, 2023

First we need to handle 0 value and NaN/missing value differently.
Also what about scatterplot?

@simzer simzer removed their assignment Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants