Fix for 480 #484
Open
Fix for 480 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simzer
reviewed
Jan 26, 2024
|
I'm not sure if we would like to have this behaviour. If the use explicitly sets a legend, they might want to have the space even if there is no legend. Usecase: there are 3 chart in a data story, 1st and 3rd have legend, but not for the 2nd. In this case the user might not want the chart to get wider then narrower. |
|
If the user wants to explicitly set a legend without drawing, then we need an option for that (an empty channel). |
# Conflicts: # CHANGELOG.md # src/chart/options/options.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #480
(probably this check is not in the right place.)