Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 support #235

Open
geoextra opened this issue Feb 7, 2024 · 4 comments
Open

Svelte 5 support #235

geoextra opened this issue Feb 7, 2024 · 4 comments

Comments

@geoextra
Copy link

geoextra commented Feb 7, 2024

When using the Calendar component in a Svelte 5 project it relies on get_current_component() from svelte/internal which has been removed.

import {destroy_component, get_current_component} from 'svelte/internal';

A possible solution is presented here with an example.

Tested with Svelte 5.0.0-next.50.

@vkurko
Copy link
Owner

vkurko commented Feb 7, 2024

Thanks for the tip. Svelte 5 support will definitely come in the future.

@bayaderpack
Copy link

This is not only place with svelte/internal there is like 100 more places unfortunately

@dummdidumm
Copy link

Svelte maintainer here. I'm interested in why you had to reach into svelte/internal. When you start the migration towards Svelte 5, I'm curious to hear if there's anything that Svelte 5 lacks that you need to not reach into internals again.

@vkurko
Copy link
Owner

vkurko commented Apr 28, 2024

Svelte maintainer here. I'm interested in why you had to reach into svelte/internal. When you start the migration towards Svelte 5, I'm curious to hear if there's anything that Svelte 5 lacks that you need to not reach into internals again.

Author of Event Calendar here 😃. @dummdidumm Thanks for the intervention. I would like to inform you that at the moment the migration to Svelte 5 has not yet been carried out.

The reason for using svelte/internal is that there are really useful functions there that will already be present in the final code, so it makes sense to reuse them in my library rather than write my own code. And for example get_current_component() it is impossible to write my own analogue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants