Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-ingest-http: Support for Python 3.12 #3153

Open
gageorgiev opened this issue Feb 21, 2024 · 0 comments
Open

vdk-ingest-http: Support for Python 3.12 #3153

gageorgiev opened this issue Feb 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gageorgiev
Copy link
Contributor

Describe the bug
Currently, the test_http_ingestion test in the functional tests section of the vdk-ingest-http seems to be failing in a 3.12 environment in a weird way: the test checks how many packets are sent to a configured http server, and expects them to be 10, each being a 1000 bytes, in total matching the size of the ingested data. However, for some reason when running in a 3.12 environment, only 9 packets are sent to it.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Create Python 3.12 environment
  2. Install vdk-ingest-http and dependencies.
  3. Run the test_http_ingestion test.

Expected behavior
10 packets are received according to the httpserver's logs.

Version (please complete the following information):

vdk-core                      0.3.1181712746
vdk-ingest-http         0.2.1156222304
@gageorgiev gageorgiev added the bug Something isn't working label Feb 21, 2024
gageorgiev added a commit that referenced this issue Feb 26, 2024
This PR adds a CICD job checking that components and plugins can be
built and tested in a Py3.12 environment.
`vdk-singer` does not support 3.12 as its dependency `tap-rest-api-msdk`
explicitly does not support it.
`vdk-ingest-http`'s tests seem to fail in an odd way - this is described
in this issue I've created -
#3153

Testing done: cicd

---------

Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant