Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart Sass compatibility #10

Open
tstahn opened this issue Nov 5, 2021 · 2 comments · May be fixed by #11
Open

Dart Sass compatibility #10

tstahn opened this issue Nov 5, 2021 · 2 comments · May be fixed by #11

Comments

@tstahn
Copy link

tstahn commented Nov 5, 2021

Are there any plans to migrate to math.div() for Dart Sass 2.0.0 compatibility? Running with Dart Sass 1.43.2 currently yields some deprecation warnings:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($rgb, 255)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
9 │     $rgb: $rgb / 255;
  │           ^^^^^^^^^^
  ╵
    node_modules/sass-color-helpers/stylesheets/color-helpers/_contrast.scss 9:11   ch-color-luminance()
    node_modules/sass-color-helpers/stylesheets/color-helpers/_contrast.scss 22:16  ch-color-contrast()
    node_modules/sass-color-helpers/stylesheets/color-helpers/_contrast.scss 37:14  ch-best-color-contrast()
    src/scss/objects/_object.frames.scss 9:25                                       @import
    src/scss/app.scss 29:9                                                          root stylesheet
@voxpelli
Copy link
Owner

voxpelli commented Nov 6, 2021

Absolutely, that and #9

PR:s are welcome 🙂

@tstahn
Copy link
Author

tstahn commented Nov 8, 2021

Sounds good. Let me see what I can come up with.

@dawaltconley dawaltconley linked a pull request Mar 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants