Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RGB(A)->HSV(A) conversion #7

Open
strarsis opened this issue Mar 1, 2017 · 3 comments
Open

Add RGB(A)->HSV(A) conversion #7

strarsis opened this issue Mar 1, 2017 · 3 comments
Labels
enhancement

Comments

@strarsis
Copy link

strarsis commented Mar 1, 2017

It would be great if also conversion from RGB(A) to HSV(A) is added.
voxpelli added a commit that referenced this issue Mar 1, 2017
@voxpelli
Add support + tests for alpha colors
6fd9da7 
Fixes #7
@voxpelli voxpelli mentioned this issue Mar 1, 2017
Open
@voxpelli
Copy link
Owner

voxpelli commented Mar 1, 2017

@strarsis Makes sense to support it, what do you think about the code I added in a PR?

@voxpelli
Copy link
Owner

@strarsis No feedback?

@strarsis
Copy link
Author

Thanks for the PR, the different color system should result in different alpha mixing.
(Originally I wondered how to generally convert RGB to HSV. -
Apparently this was is possible by just passing a RGB value to ch-hsl-to-hsv(...).)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voxpelli @strarsis