Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User defined routes can override /oauth/callback and break OAuth flow #2029

Closed
infomiho opened this issue May 12, 2024 · 0 comments · Fixed by #2039
Closed

User defined routes can override /oauth/callback and break OAuth flow #2029

infomiho opened this issue May 12, 2024 · 0 comments · Fixed by #2039
Assignees
Labels
bug Something isn't working

Comments

@infomiho
Copy link
Contributor

Context: https://ptb.discord.com/channels/686873244791210014/1238173111363305574/1239325290824732673

If users define a wildcard route (to serve as a error page for missing routes) they will override the OAuth callback because user routes come before Wasp defined routes.

We should make sure Wasp defined routes are before in the router.tsx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant