Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make format "io.weaviate.spark" #13

Open
sam-h-bean opened this issue Nov 12, 2022 · 4 comments
Open

Make format "io.weaviate.spark" #13

sam-h-bean opened this issue Nov 12, 2022 · 4 comments

Comments

@sam-h-bean
Copy link
Collaborator

The format to write is currently io.weaviate.spark.Weaviate which is a little wonky. Would be good to try to maintain convention and figure out how to just shave it down to io.weaviate.spark.

@samos123
Copy link
Collaborator

What about io.weaviate.DataSource? that's the pattern that neo4j uses

@sam-h-bean
Copy link
Collaborator Author

ES uses org.elasticsearch.spark.sql which is another option but I think they notion of a SQL datasource is kind of defunct in Spark 3.

@antas-marcin
Copy link
Contributor

for the java client we are now using technology.weaviate: https://mvnrepository.com/artifact/technology.semi.weaviate

Maybe technology.weaviate.spark-connector would be a good name?

@trengrj
Copy link
Member

trengrj commented Aug 1, 2023

Given we have some use now I don't see a lot of utility in changing from io.weaviate.spark.Weaviate -> io.weaviate.DataSource. Are we ok to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants