Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when weaviate and/or client are outdated #41

Open
dirkkul opened this issue Apr 13, 2023 · 6 comments
Open

Warn when weaviate and/or client are outdated #41

dirkkul opened this issue Apr 13, 2023 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dirkkul
Copy link
Contributor

dirkkul commented Apr 13, 2023

Some users use very old versions of weaviate and client. We should warn them if it the minor version is 3 or more versions behind the last release.

Eg currently the last Weaviate version is 1.18.3, so we would warn users of 1.15 or below. We could do the same for the client versions.

@dirkkul dirkkul added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 13, 2023
@Abhijithchintu
Copy link
Contributor

Hi @dirkkul . Is this issue still open. If it is open, can i work on this issue ?

@dirkkul
Copy link
Contributor Author

dirkkul commented Jul 10, 2023

Hi, yes this is still open!

Here are the python PRs that implemeted that functionality:
weaviate/weaviate-python-client#343
weaviate/weaviate-python-client#299

@Abhijithchintu
Copy link
Contributor

Please review
#81

@tsmith023
Copy link
Contributor

@Abhijithchintu, thanks for the contribution! #81 is now merged, which covers warning for outdated Weaviate. Warning for an outdated client is still open, would you like to open a PR for that also?

@Abhijithchintu
Copy link
Contributor

Yes , i will work on warning for an outdated client. I have few doubts in that.

  1. how to fetch typescript client version
  2. Should we show the warning for client version (if applicable ) at the same time as weaviate version warning.

@tsmith023
Copy link
Contributor

In the Python client, the version of the package is obtained here, this is then used here when instantiating a Connection object alongside the check for the Weaviate server version.

I would say we follow a similar logic for the TypeScript client so warn of outdated client in the same place as warning for outdated server. For retrieving the version, there are concerns in TypeScript around revealing the entire package.json file to the browser when this client is used in frontend apps. As such, the recommendation here should be followed.

This prebuild script will be used within other build, test, and package scripts to ensure the version is always up-to-date without compromising the security of the package.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants