-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when weaviate and/or client are outdated #41
Comments
Hi @dirkkul . Is this issue still open. If it is open, can i work on this issue ? |
Hi, yes this is still open! Here are the python PRs that implemeted that functionality: |
Please review |
@Abhijithchintu, thanks for the contribution! #81 is now merged, which covers warning for outdated Weaviate. Warning for an outdated client is still open, would you like to open a PR for that also? |
Yes , i will work on warning for an outdated client. I have few doubts in that.
|
In the Python client, the version of the package is obtained here, this is then used here when instantiating a I would say we follow a similar logic for the TypeScript client so warn of outdated client in the same place as warning for outdated server. For retrieving the version, there are concerns in TypeScript around revealing the entire This |
Some users use very old versions of weaviate and client. We should warn them if it the minor version is 3 or more versions behind the last release.
Eg currently the last Weaviate version is 1.18.3, so we would warn users of 1.15 or below. We could do the same for the client versions.
The text was updated successfully, but these errors were encountered: