Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of numpy arrays in vector of batch import #1013

Conversation

manu156
Copy link

@manu156 manu156 commented Apr 20, 2024

resolves #1002

@dirkkul
Copy link
Collaborator

dirkkul commented May 6, 2024

Hey manu,

thanks for contributing, but we do not want to add numpy to our dependencies only to be able to accept numpy arrays as vectors.

We already have tests with a numpy mock here: integration/test_batch_v4.py - I think the best way forward would be to find out why the mock-tests succeed while real numpy arrays fail and then adapt the mocks and the code that handles the arrays

@dirkkul dirkkul closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insert_many silently discards vectors if they're NumPy arrays
2 participants