Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding props to a component are not directly reflected #21

Open
SoftHai opened this issue Mar 28, 2020 · 7 comments
Open

Adding props to a component are not directly reflected #21

SoftHai opened this issue Mar 28, 2020 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@SoftHai
Copy link

SoftHai commented Mar 28, 2020

Hi,

when having a component without props definition (initial) and then adding some, the Webcodesk UI don't shows automatically the added props in the preview screen or when using the component. A Reload of the Webcodesk application, in the browser, is needed to see the changes.

  • Create a component without props definition (in my case a *.tsx but maybe a general issue)
  • Open the preview in Webcodesk
  • Add some props-definitions to the component and defaults
  • Go to Webcodesk
    • The source code shows the new version with the props-definition
    • The preview works with the new props (Defaults)
    • The Props are not displayed in the right properties panel
  • Reload the Website
    • Properties are displayed
  • Add an additional property to the definition
  • Go to Webcodesk
  • Component works with the new added Props
    • The properties view is not updated
@ipselon
Copy link
Contributor

ipselon commented Mar 29, 2020

@SoftHai,

I encounter the same issue only in Windows 7. Actually, I'm not sure about the reason of the issue though.

Here are the systems that I've tested:

  • Mac OS (any version) - success
  • Ubuntu Linux - success
  • Windows 10 - success
  • Windows 7 - failed

I'd much appreciate it if you help me to understand the reason in your OS. Could you tell me what OS and NodeJS version you are using?

@SoftHai
Copy link
Author

SoftHai commented Mar 29, 2020

Hi,

sure, I using Windows 10 Enterprise (1909) with Node.js (13.6.0). Also I'm using Chrome (80.0)
Hope that helps.

@ipselon
Copy link
Contributor

ipselon commented Mar 29, 2020

@SoftHai,

Would you mind to provide testing of this case?

  1. Clone the source code and install deps by yarn install command.
  2. Find the src/srv/watcher.js file in the source code root dir.
  3. Uncomment all lines with console.info function in the found file.
  4. Build the distribution by command: yarn build.
  5. Set the -d argument in the server script in the package.json (83-d line) to the directory path where your project is.
  6. Run Webcodesk: yarn server.
  7. Watch in the terminal output lines when you change source code files in your project.

The idea is to track if the watcher library can see changes in files. If there is no activity I'll try to investigate the reason.

@ipselon ipselon added the bug Something isn't working label Mar 29, 2020
@ipselon
Copy link
Contributor

ipselon commented Mar 29, 2020

The watcher is on the server side, so you should see console log in the terminal window (command line) where you were typing yarn wcd

@SoftHai
Copy link
Author

SoftHai commented Mar 30, 2020

Hi,
there is no logs in the console window:
image

@ipselon
Copy link
Contributor

ipselon commented Mar 31, 2020

@SoftHai, thanks.

That means that chokidar library does not work on your OS :-(

@SoftHai
Copy link
Author

SoftHai commented Mar 31, 2020

Mhhh strange. Don't have a very exotic setup ;-)
But okay, when it is more an issue with my system then there is not much you can do / fix.
I'm now aware of this behavior and have to click the refresh button once more as usual, to get my changes reflected.

thanks for your support.
Feel free to close this issue if you want.

@ipselon ipselon added help wanted Extra attention is needed and removed bug Something isn't working labels Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants