-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to upgrade all packages #4
Comments
Could there be a better way than to |
Updates might require the package file to be regenerated. You know if the labels have changed or something? |
@nithin-bose Yeah, that's an issue. Particularly if the user has edited the package file. Perhaps the package file could be blank by default (except for |
Hmm that makes sense but would that add a significant delay to command execution?? Also existing users might never get the updated label values in the image, unless they reinstall the app. |
An image inspect is extremely fast. (On the order of 10ms with Docker for Mac IIRC, but we could benchmark it.) Backwards compatibility is certainly an issue. Perhaps Whalebrew could remove labels which match the value in the image to convert them to this new format. To make it a one-off, we could add a |
How about we use image inspect as default values?? That is when a command is run the following steps happen:
If we use the the above method, we should be able to support current installs as well without a version number. The only corner case for existing installs is if the value of a label has changed or if a label has been removed in a newer version, in which case the user will have to reinstall the app. Even with a version number, its not trivial to update the version of a pkg file of an installed app and is probably easier to just reinstall the app. Thoughts?? |
Iterate through all the packages and run
docker pull
on them:Ref #3
The text was updated successfully, but these errors were encountered: