Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the end of for loops and while loops more understandable #3734

Open
waynehamadi opened this issue May 15, 2024 · 0 comments
Open

Make the end of for loops and while loops more understandable #3734

waynehamadi opened this issue May 15, 2024 · 0 comments
Assignees

Comments

@waynehamadi
Copy link

waynehamadi commented May 15, 2024

Screenshot 2024-05-15 at 11 38 37 AM

Look, this is the end of an if statement, a for loop and while loop.
And when looking at this, I don't know which business logic they correspond to, I have to go back up to remember "Oh, this is doing this, ok."

I will let you find the appropriate solution. A suggestion:
Repeat what the for loop says, but put an (end) or something like that.

For example
"Iterate through contacts"
will finish
"(END) Iterate through contacts"

This way we know what something does. To me this is the main benefit of Windmill, is to increase maintainability and accessibility of a codebase

And yes you loose the information that you COLLECT results. This is the downside of this approach.

The upside is more readability.

@waynehamadi waynehamadi changed the title feature: Make the end of for loops and while loops more understandable May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants