Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Collection: Improve Handling of Currency Input Formatting in Price Range Filter #47351

Closed
Tracked by #43263
imanish003 opened this issue May 10, 2024 · 0 comments · Fixed by #47354
Closed
Tracked by #43263
Assignees
Labels
block: product collection Issues related to the Product Collection block focus: FSE Issues related to Full Site Editing team: Kirigami & Origami type: bug The issue is a confirmed bug.

Comments

@imanish003
Copy link
Contributor

imanish003 commented May 10, 2024

@dinhtungdu highlighted an issue within the Price Range filter of the Product Collection block, where the input handling for currency formatting is overly strict. The current logic clears the input if the space between the currency symbol and the numeric value is omitted (e.g., typing "20$" instead of "20 $"). This happens when in Curreny Options, currency position is "Right with space" as shown in screenshot below:
image

Steps to reproduce the issue

  1. Add the 'Product Collection' block to a new post
  2. Add "Price Range" filter in inspector controls
  3. In Currency Options, set currency position to "Right with space" as shown in screenshot below:
image
  1. Add any value to "Min" field of Price Range filter, for example 20. You will notice that it will have a space between value & currency symbol i.e. "20 $".
  2. Now remove the space between value & currency symbol i.e. "20$". You will notice that after submitting this value, it clears the input field. Here is a quick demo video:
Screen.Recording.2024-03-07.at.16.17.29.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: product collection Issues related to the Product Collection block focus: FSE Issues related to Full Site Editing team: Kirigami & Origami type: bug The issue is a confirmed bug.
Projects
None yet
1 participant