Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency for community-label.yml causing failed workflow runs #47179

Closed
5 tasks done
tammullen opened this issue May 6, 2024 · 1 comment · Fixed by #47355
Closed
5 tasks done

Concurrency for community-label.yml causing failed workflow runs #47179

tammullen opened this issue May 6, 2024 · 1 comment · Fixed by #47355
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Vortex WooCommerce monorepo tools and test suite. type: bug The issue is a confirmed bug.

Comments

@tammullen
Copy link
Contributor

Prerequisites

  • I have carried out troubleshooting steps and I believe I have found a bug.
  • I have searched for similar bugs in both open and closed issues and cannot find a duplicate.

Describe the bug

Some of the workflow runs for community-label.yml are failing.
https://github.com/woocommerce/woocommerce/actions/workflows/community-label.yml?query=is%3Acancelled

They fail with error Canceling since a higher priority waiting request for 'Add Community Label, Assign Reviewers-refs/heads/trunk' exists

The workflow currently has this concurrency step

concurrency:
    group: ${{ github.workflow }}-${{ github.ref }}
    cancel-in-progress: true

The github.ref is always returning trunk instead of the branch name so it appears like the workflow is already running when multiple are triggered at the same time. Perhaps use github.head_ref instead https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request_target-workflow-based-on-the-head-or-base-branch-of-a-pull-request

Expected behavior

All runs pass

Actual behavior

Some runs fail if there is another run in progress at the same time.
https://github.com/woocommerce/woocommerce/actions/workflows/community-label.yml?query=is%3Acancelled

Steps to reproduce

Go to https://github.com/woocommerce/woocommerce/actions/workflows/community-label.yml
See some runs are cancelled due to error

WordPress Environment

n/a

Isolating the problem

  • I have deactivated other plugins and confirmed this bug occurs when only WooCommerce plugin is active.
  • This bug happens with a default WordPress theme active, or Storefront.
  • I can reproduce this bug consistently using the steps above.
@tammullen tammullen added type: bug The issue is a confirmed bug. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. focus: monorepo infrastructure Issues and PRs related to monorepo tooling. team: Vortex WooCommerce monorepo tools and test suite. labels May 6, 2024
@adimoldovan
Copy link
Contributor

Noting that this was affecting the pr-project-label.yml workflow too and was fixed with #45793. We should check if other workflows are affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Vortex WooCommerce monorepo tools and test suite. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants